Hi Robert,
> Has anybody done some testing of this patch with the WAL consistency
> checker? Like, create some tables with indexes that have INCLUDE
> columns, set up a standby, enable consistency checking, pound the
> master, and see if the standby bails?
I've decided to run such a test. It looks like there is a bug indeed.
Steps to reproduce:
0. Apply a patch.
1. Build PostgreSQL using quick-build.sh [1]
2. Install master and replica using install.sh [2]
3. Download test.sql [3]
4. Run: `cat test.sql | psql`
5. In replica's logfile:
```
FATAL: inconsistent page found, rel 1663/16384/16396, forknum 0, blkno 1
```
> Has anybody tested this patch with amcheck? Does it break amcheck?
Amcheck doesn't complain.
[1] https://github.com/afiskon/pgscripts/blob/master/quick-build.sh
[2] https://github.com/afiskon/pgscripts/blob/master/install.sh
[3] http://afiskon.ru/s/88/93c544e6cf_test.sql
--
Best regards,
Aleksander Alekseev
