Re: [HACKERS] pg_dump emits ALTER TABLE ONLY partitioned_table - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [HACKERS] pg_dump emits ALTER TABLE ONLY partitioned_table
Date
Msg-id 20170217133251.GK9812@tamriel.snowman.net
Whole thread Raw
In response to [HACKERS] pg_dump emits ALTER TABLE ONLY partitioned_table  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: [HACKERS] pg_dump emits ALTER TABLE ONLY partitioned_table  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
Amit,

* Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> In certain cases, pg_dump's dumpTableSchema() emits a separate ALTER TABLE
> command for those schema elements of a table that could not be included
> directly in the CREATE TABLE command for the table.

Any chance we could start adding regression tests for how pg_dump
handles partitions?  I'm just about to the point where I have pretty
much everything else covered (at least in pg_dump.c, where it's not a
hard-to-reproduce error/exit case, or something version-dependent).

If you have any questions about how the TAP tests for pg_dump work, or
about how to generate code-coverage checks to make sure you're at least
hitting every line (tho, of course, not every possible path), let me
know.  I'd be happy to explain them.

Thanks!

Stephen

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Sum aggregate calculation for single precsion real
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Help text for pg_basebackup -R