Re: Bogus sizing parameters in some AllocSetContextCreate calls - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Bogus sizing parameters in some AllocSetContextCreate calls
Date
Msg-id 20160827190933.3hmzdrx4hpnvrhjo@alap3.anarazel.de
Whole thread Raw
In response to Bogus sizing parameters in some AllocSetContextCreate calls  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Bogus sizing parameters in some AllocSetContextCreate calls  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2016-08-27 14:08:44 -0400, Tom Lane wrote:
> The standard calling pattern for AllocSetContextCreate is
> Barring objection, I propose to make these changes in HEAD and 9.6.
> I don't feel a great need to adjust the back branches --- although there
> might be some argument for adding these new calling-pattern macros to the
> back branches so as not to create a back-patching hazard for patches
> that add new AllocSetContextCreate calls.

I think we might also / instead want to think about replacing a lot of
those AllocSetContextCreate with a wrapper function. Currently is really
rather annoying to experiment with switching the default allocator
out. And if we're touching all that code anyway ...

Andres



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Renaming of pg_xlog and pg_clog
Next
From: Tom Lane
Date:
Subject: Re: Bogus sizing parameters in some AllocSetContextCreate calls