Re: Accidentally parallel unsafe functions - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Accidentally parallel unsafe functions
Date
Msg-id 20160429231245.GA173958@alvherre.pgsql
Whole thread Raw
In response to Accidentally parallel unsafe functions  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: Accidentally parallel unsafe functions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Andreas Karlsson wrote:
> Hi,
> 
> I am currently looking into adding the correct parallel options to all
> functions in the extensions and I noticed that some built-in functions seems
> to have been marked as unsafe by accident. The main culprit is
> system_views.sql which redefines these functions and removes the parallel
> safe flag.

Surely CREATE OR REPLACE should keep whatever the flag was, rather than
ovewrite it with a bogus value if not specified?  In other words IMO the
CREATE OR REPLACE code needs changing, not system_views.sql.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: VS 2015 support in src/tools/msvc
Next
From: Tom Lane
Date:
Subject: Re: Accidentally parallel unsafe functions