Re: [CommitFest App] Feature request -- review e-mail additions - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [CommitFest App] Feature request -- review e-mail additions
Date
Msg-id 20160330174744.GA978880@alvherre.pgsql
Whole thread Raw
In response to [CommitFest App] Feature request -- review e-mail additions  (José Luis Tallón <jltallon@adv-solutions.net>)
Responses Re: [CommitFest App] Feature request -- review e-mail additions  (Robert Haas <robertmhaas@gmail.com>)
Re: [CommitFest App] Feature request -- review e-mail additions  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
José Luis Tallón wrote:

>     Just wanted to suggest two minor mods to the review e-mails
> auto-generated by the app:
> 
> * Prepend a [review] tag to the e-mail subject
>     ... so that e-mails sent to -hackers will read  " [HACKERS] [review]
> <patch title goes here>"

Changing the subject of an email causes Gmail to break the threads, so
anything in that line should be discouraged.  -1 from me.  I would be
happier if the subject of the submission email is kept intact, i.e. not
use the patch title that was used in commitfest app but use the one in
the email.  These often differ.

> * Auto-CC the patch author on this e-mail
>     I guess this should speed up reactions / make communication a bit more
> fluid.

Yes, strong +1 on this.

3) Have the auto-generated emails insert In-Reply-To headers (and
perhaps References).

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: José Luis Tallón
Date:
Subject: [CommitFest App] Feature request -- review e-mail additions
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Introduce SP-GiST operator class over box.