Re: [COMMITTERS] pgsql: Introduce SP-GiST operator class over box. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Introduce SP-GiST operator class over box.
Date
Msg-id 31050.1459360502@sss.pgh.pa.us
Whole thread Raw
List pgsql-hackers
Teodor Sigaev <teodor@sigaev.ru> writes:
> Introduce SP-GiST operator class over box.

All of the Windows buildfarm members are failing on this patch.
It looks like the problem is that the test cases suppose that type
box will allow "infinity" as a coordinate value.  But box_in just
uses strtod() to read coordinates, and that has platform-dependent
behavior, which in this case includes not recognizing "infinity".

I'm inclined to think that the best fix is to rearrange things
so that the box I/O routines use float8in and float8out for
coordinates, rather than assuming that direct use of the platform
primitives is sufficient.

Barring better ideas, I'll go make that happen.

Welcome to the club of people who have broken the Windows build
this week ;-)
        regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [CommitFest App] Feature request -- review e-mail additions
Next
From: Robert Haas
Date:
Subject: Re: pg_dump dump catalog ACLs