Re: [CommitFest App] Feature request -- review e-mail additions - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [CommitFest App] Feature request -- review e-mail additions
Date
Msg-id CA+TgmoZPeQy+AY80kk3fYfZMCGGX-fDSyaHdKa0nr9qHAwdcbA@mail.gmail.com
Whole thread Raw
In response to Re: [CommitFest App] Feature request -- review e-mail additions  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Wed, Mar 30, 2016 at 1:47 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> José Luis Tallón wrote:
>>     Just wanted to suggest two minor mods to the review e-mails
>> auto-generated by the app:
>>
>> * Prepend a [review] tag to the e-mail subject
>>     ... so that e-mails sent to -hackers will read  " [HACKERS] [review]
>> <patch title goes here>"
>
> Changing the subject of an email causes Gmail to break the threads, so
> anything in that line should be discouraged.  -1 from me.  I would be
> happier if the subject of the submission email is kept intact, i.e. not
> use the patch title that was used in commitfest app but use the one in
> the email.  These often differ.

I entirely agree with Alvaro.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: dealing with extension dependencies that aren't quite 'e'
Next
From: Robert Haas
Date:
Subject: Re: So, can we stop supporting Windows native now?