Re: track_commit_timestamp and COMMIT PREPARED - Mailing list pgsql-hackers

Hi Fujii, thanks for the review.  I have pushed the patch to 9.5 and
master.

Fujii Masao wrote:

> @@ -5321,7 +5333,7 @@ xact_redo_commit(xl_xact_parsed_commit *parsed,
>      /* Set the transaction commit timestamp and metadata */
>      TransactionTreeSetCommitTsData(xid, parsed->nsubxacts, parsed->subxacts,
>                                     commit_time, origin_id,
> -                                   false);
> +                                   false, true);
> 
> Why does xact_redo_commit always set replaying_xlog and write_xlog to
> false and true, respectively? ISTM that they should be opposite...

A stupid oversight on my part.  Thanks for pointing it out.

Thanks, Petr, for the patches.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services