Postgres Pro
Downloads
Home   >   mailing lists

Re: psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx - Mailing list pgsql-hackers

From Jeevan Chalke
Subject Re: psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx
Date
Msg-id 20150529072848.24903.96159.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
Tree view 
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            not tested

I agree with Peter that "We don't tab-complete everything we possibly could", but using tabs after "SET ROLE TO "
provides"DEFAULT" as an option which seems wrong.
 
This patch adds list of roles over there, which I guess good to have than giving something unusual.

I reviewed this straight forward patch and looks good to me.

Since we might not want this, review is done and thus passing it to committer to decide.

The new status of this patch is: Ready for Committer

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: RFC: Remove contrib entirely
Next
From: Pavel Stehule
Date:
Subject: Re: psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx