Michael Paquier wrote:
> On Tue, Feb 24, 2015 at 3:13 PM, Rushabh Lathia <rushabh.lathia@gmail.com>
> wrote:
> > rushabh@rushabh-centos-vm:dump_test$ cat dump_test--1.0.sql
> > /* dump_test/dump_test--1.0.sql */
Hm. I think it would be a good idea to collect these extension files
somewhere so that pg_dump hacking can be tested with them. Right now,
the extension part of pg_dump is easy to break in subtle ways, which
discourages anyone who wants to meddle with it.
Maybe something in src/test/modules could keep these files so that
pg_dump can be tested. Is anybody interested in doing that?
> Btw, perhaps you may have noticed, but I marked this patch as rejected... I
> don't think it makes much sense to put restrictions in this code path after
> finding my way through all the stuff of pg_dump.
Please don't do that -- I mean don't use the commitfest app as the only
source for random bits of data. If you want to reject a patch, please
make sure to point that out in the email thread. It's impossible to go
from email archives to commitfest entries.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
