Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Date
Msg-id 20141117133642.GX1791@alvin.alvh.no-ip.org
Whole thread Raw
In response to Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera wrote:

> I wrote an identical patch on Saturday and watched it pass
> CLOBBER_CACHE_ALWAYS test on Sunday.  But the reason I didn't push is I
> couldn't understand *why* is there a problem here.  I imagine that the
> source of the issue is supposed to be a relcache invalidation that takes
> place (in the original code) after reindex_index changes relpersistence,
> and before RelationSetNewRelfilenode() creates the filenode.  But at
> what point does that code absorb invalidation messages?  Or is there a
> completely different mechanism that causes the problem?  If so, what?

Ah, it's the anti-collision stuff in GetNewOid(), isn't it.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Next
From: Heikki Linnakangas
Date:
Subject: Re: WAL format and API changes (9.5)