Make LWLockAcquireCommon() inline? - Mailing list pgsql-hackers

From Andres Freund
Subject Make LWLockAcquireCommon() inline?
Date
Msg-id 20140830122240.GD8526@awork2.anarazel.de
Whole thread Raw
Responses Re: Make LWLockAcquireCommon() inline?
List pgsql-hackers
Hi,

when profiling optimized builds (linux, gcc 4.9) it's currently
LWLockAcquireCommon() showing up, not it's callers. Instruction level
profiles show that the tests for valptr show up in profiles to some
extent. Since most callers don't need the valptr logic it seems prudent
to mark the function inline which will then eliminate the superflous
branches.

Arguments against?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Atri Sharma
Date:
Subject: Re: COPY and heap_sync
Next
From: Kevin Grittner
Date:
Subject: Re: delta relations in AFTER triggers