Re: Make LWLockAcquireCommon() inline? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Make LWLockAcquireCommon() inline?
Date
Msg-id 20140901095823.GC7400@awork2.anarazel.de
Whole thread Raw
In response to Make LWLockAcquireCommon() inline?  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On 2014-08-30 14:22:40 +0200, Andres Freund wrote:
> Hi,
> 
> when profiling optimized builds (linux, gcc 4.9) it's currently
> LWLockAcquireCommon() showing up, not it's callers. Instruction level
> profiles show that the tests for valptr show up in profiles to some
> extent. Since most callers don't need the valptr logic it seems prudent
> to mark the function inline which will then eliminate the superflous
> branches.
> 
> Arguments against?

Done.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Re: PL/pgSQL 2
Next
From: Marko Tiikkaja
Date:
Subject: Re: PL/pgSQL 2