BUFFER_LOCK_EXCLUSIVE is used in ginbuildempty(). - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject BUFFER_LOCK_EXCLUSIVE is used in ginbuildempty().
Date
Msg-id 20140716.171304.232876096.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
Responses Re: BUFFER_LOCK_EXCLUSIVE is used in ginbuildempty().  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hello,

As far as I see gin seems using GIN_EXCLUSIVE instead of
BUFFER_LOCK_EXCLUSIVE for LockBuffer, but the raw
BUFFER_LOCK_EXCLUSIVE appears in ginbuildempty().

Does it has a meaning to fix them to GIN_EXCLUSIVE?

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/access/gin/gininsert.c b/src/backend/access/gin/gininsert.c
index b27cae3..004b3a9 100644
--- a/src/backend/access/gin/gininsert.c
+++ b/src/backend/access/gin/gininsert.c
@@ -442,10 +442,10 @@ ginbuildempty(PG_FUNCTION_ARGS)    /* An empty GIN index has two pages. */    MetaBuffer =
ReadBufferExtended(index,INIT_FORKNUM, P_NEW, RBM_NORMAL, NULL);
 
-    LockBuffer(MetaBuffer, BUFFER_LOCK_EXCLUSIVE);
+    LockBuffer(MetaBuffer, GIN_EXCLUSIVE);    RootBuffer =        ReadBufferExtended(index, INIT_FORKNUM, P_NEW,
RBM_NORMAL,NULL);
 
-    LockBuffer(RootBuffer, BUFFER_LOCK_EXCLUSIVE);
+    LockBuffer(RootBuffer, GIN_EXCLUSIVE);    /* Initialize and xlog metabuffer and root buffer. */
START_CRIT_SECTION();

pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: [BUG?] tuples from file_fdw has strange xids.
Next
From: Magnus Hagander
Date:
Subject: Re: [bug fix] pg_ctl always uses the same event source