Re: IMPORT FOREIGN SCHEMA statement - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: IMPORT FOREIGN SCHEMA statement
Date
Msg-id 20140709182939.GP6390@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: IMPORT FOREIGN SCHEMA statement  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
> > With that, I am marking this patch as ready for committer.
> 
> I've started looking at this patch.  I wonder whether it's really such
> a great idea to expect the FDW to return a list of parsetrees for
> CREATE FOREIGN TABLE commands; that seems like a recipe for breakage
> anytime we change the parsetree representation, say add a field to
> ColumnDef.  The alternative I'm thinking about is to have the FDW pass
> back a list of strings, which would be textual CREATE FOREIGN TABLE
> commands.

.oO(json blobs as in the DDL deparse patch ...)

(I don't know if they are really suitable.  I have no idea how this
patch works.)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: tweaking NTUP_PER_BUCKET
Next
From: David G Johnston
Date:
Subject: Re: how to find the order of joins from Explain command XML plan output in PostgreSQL