Re: lo_create(oid, bytea) breaks every extant release of libpq - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: lo_create(oid, bytea) breaks every extant release of libpq
Date
Msg-id 20140612145604.GK18688@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: lo_create(oid, bytea) breaks every extant release of libpq  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: lo_create(oid, bytea) breaks every extant release of libpq  (Robert Haas <robertmhaas@gmail.com>)
Re: lo_create(oid, bytea) breaks every extant release of libpq  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> >> lo_new() or lo_make()?  An earlier draft of the patch that added
> >> lo_create(oid, bytea) had a similar function named make_lo().
> 
> It appears that lo_make() has a small plurality, but before we lock
> that name in, there was one other idea that occurred to me: the
> underlying C function is currently named lo_create_bytea(), and
> that seems like not an awful choice for the SQL name either.
> 
> Any other votes out there?

I was also going to suggest lo_create_bytea().  Another similar
possibility would be lo_from_bytea() -- or, since we have overloading
(and we can actually use it in this case without breaking libpq), we
could just have lo_from(oid, bytea).

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: lo_create(oid, bytea) breaks every extant release of libpq
Next
From: Robert Haas
Date:
Subject: Re: Shared memory changes in 9.4?