Re: Useless "Replica Identity: NOTHING" noise from psql \d - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Useless "Replica Identity: NOTHING" noise from psql \d
Date
Msg-id 20140323034757.GC5606@momjian.us
Whole thread Raw
In response to Re: Useless "Replica Identity: NOTHING" noise from psql \d  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Useless "Replica Identity: NOTHING" noise from psql \d  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Useless "Replica Identity: NOTHING" noise from psql \d  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On Tue, Dec 17, 2013 at 09:37:09AM -0500, Robert Haas wrote:
> > Patch attached.
>
> I vote for showing it only with +, but regardless of whether the value
> matches the expected default.  I'd keep the relkind test, though,
> because I think I noticed that it currently shows up for indexes,
> which is dumb.

Is this the patch you had in mind?  I kept the pg_catalog filter.  Do we
want to always show the replica identity line for \d+?

    test=> \d+ test
                             Table "public.test"
     Column |  Type   | Modifiers | Storage | Stats target | Description
    --------+---------+-----------+---------+--------------+-------------
     x      | integer |           | plain   |              |
    Replica Identity: full
    Has OIDs: no

I used lower-case for the value, rather than all-caps.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: jsonb status
Next
From: Amit Kapila
Date:
Subject: Re: Fwd: Proposal: variant of regclass