Re: FW: REVIEW: Allow formatting in log_line_prefix - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: FW: REVIEW: Allow formatting in log_line_prefix
Date
Msg-id 20130924165104.GQ4832@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: FW: REVIEW: Allow formatting in log_line_prefix  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: FW: REVIEW: Allow formatting in log_line_prefix
List pgsql-hackers
David Rowley escribió:

> I do see a 15-18% slow down with the patched version, so perhaps I'll need
> to look to see if I can speed it up a bit, although I do feel this
> benchmark is not quite a normal workload.

Ouch.  That's certainly way too much.  Is the compiler inlining
process_log_prefix_padding()?  If not, does it do it if you add "inline"
to it?  That might speed up things a bit.  If that's not enough, maybe
you need some way to return to the original coding for the case where no
padding is set in front of each option.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: [PATCH] bitmap indexes
Next
From: Stephen Frost
Date:
Subject: Re: record identical operator