Re: pgsql: Add support for piping COPY to/from an external program. - Mailing list pgsql-committers

Heikki Linnakangas wrote:

> This creates a new function in pgport, wait_result_to_str(), which can
> be used to convert the exit status of a process, as returned by wait(3),
> to a human-readable string.

You have this:

+#ifndef FRONTEND
+   result = pstrdup(str);
+#else
+   result = strdup(str);
+#endif

This kind of thing is no longer necessary.  In frontend, libpgcommon
provides a pstrdup() implementation which is strdup() plus error check,
so you can reduce the above to simply

    result = pstrdup(str);

and it should work everywhere.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services