Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Blind attempt at fixing the non-MSVC Windows builds - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Blind attempt at fixing the non-MSVC Windows builds
Date
Msg-id 20130222145936.GF19114@awork2.anarazel.de
Whole thread Raw
In response to pgsql: Blind attempt at fixing the non-MSVC Windows builds  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-committers
Tree view 
On 2013-02-22 14:55:06 +0000, Alvaro Herrera wrote:
> Blind attempt at fixing the non-MSVC Windows builds
>
> Apparently, they need -DBUILDING_DLL for the Assert() declarations to
> work correctly.

More specifically, they need that do access any PGDLLIMPORT symbols. Of
which
extern PGDLLIMPORT bool assert_enabled;
is one. So that seems like the appropriate fix.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Add support for piping COPY to/from an external program.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Improve pg_upgrade commentary on multixact change