Re: missing description initdb manual - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: missing description initdb manual
Date
Msg-id 20120414.185435.754349350895430410.t-ishii@sraoss.co.jp
Whole thread Raw
In response to Re: missing description initdb manual  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: missing description initdb manual  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
>> --text-search-config option is missing in document too.  Also pg_ctl's
>> long name options, such as --silent, are missing in document.
> 
> Thanks for the info. I will add them as well unless someone beats me.

Done.

BTW, while editing the document, I noticed that pg_ctl.c's help
message lacks some long options which are actually in the source code:
'--timeout' and '--mode'.  Included is the proposed patch to fix the
problem. If there's no objection, I would like to commit it. Comments?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 8ac4fe8..99a1907 100644
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -1764,7 +1764,7 @@ do_help(void)    printf(_("\nCommon options:\n"));    printf(_("  -D, --pgdata DATADIR   location
ofthe database storage area\n"));    printf(_("  -s, --silent           only print errors, no informational
messages\n"));
-    printf(_("  -t SECS                seconds to wait when using -w option\n"));
+    printf(_("  -t, --timeout SECS     seconds to wait when using -w option\n"));    printf(_("  -w
wait until operation completes\n"));    printf(_("  -W                     do not wait until operation completes\n"));
 printf(_("  --help                 show this help, then exit\n"));
 
@@ -1783,7 +1783,7 @@ do_help(void)     "                         (PostgreSQL server executable) or initdb\n"));
printf(_(" -p PATH-TO-POSTGRES    normally not necessary\n"));    printf(_("\nOptions for stop or restart:\n"));
 
-    printf(_("  -m SHUTDOWN-MODE   can be \"smart\", \"fast\", or \"immediate\"\n"));
+    printf(_("  -m, --mode SHUTDOWN-MODE   can be \"smart\", \"fast\", or \"immediate\"\n"));    printf(_("\nShutdown
modesare:\n"));    printf(_("  smart       quit after all clients have disconnected\n")); 

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: docs: WITH queries and VALUES
Next
From: Fujii Masao
Date:
Subject: Re: xlog location arithmetic