Re: missing description initdb manual - Mailing list pgsql-hackers

From Tom Lane
Subject Re: missing description initdb manual
Date
Msg-id 14193.1334413977@sss.pgh.pa.us
Whole thread Raw
In response to Re: missing description initdb manual  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: missing description initdb manual
List pgsql-hackers
Tatsuo Ishii <ishii@postgresql.org> writes:
> BTW, while editing the document, I noticed that pg_ctl.c's help
> message lacks some long options which are actually in the source code:
> '--timeout' and '--mode'.  Included is the proposed patch to fix the
> problem. If there's no objection, I would like to commit it. Comments?

I think this line needs some more thought:

> -    printf(_("  -m SHUTDOWN-MODE   can be \"smart\", \"fast\", or \"immediate\"\n"));
> +    printf(_("  -m, --mode SHUTDOWN-MODE   can be \"smart\", \"fast\", or \"immediate\"\n"));

because it's not respecting the intended alignment of the explanation
column.  (It wasn't before, either, but that's not an excuse to not fix
it.)  I think you could make it read just "-m, --mode MODE" and then
there would be room to align this switch's explanation with the ones
above it.  I'm tempted to also say that the explanation should beMODE can be \"smart\", \"fast\", or \"immediate\"
        regards, tom lane


pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.
Next
From: Fujii Masao
Date:
Subject: Re: column name of pg_stat_replication.backend_start