Re: Online base backup from the hot-standby - Mailing list pgsql-hackers

From Jun Ishiduka
Subject Re: Online base backup from the hot-standby
Date
Msg-id 201110130502.p9D52vaD009464@ccmds32.silk.ntts.co.jp
Whole thread Raw
In response to Re: Online base backup from the hot-standby  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Online base backup from the hot-standby  (Jun Ishiduka <ishizuka.jun@po.ntts.co.jp>)
List pgsql-hackers
Sorry.
I was not previously able to answer fujii's all comments.
This is the remaining answers.


> +    LWLockAcquire(WALInsertLock, LW_EXCLUSIVE);
> +    XLogCtl->Insert.fullPageWrites = fullPageWrites;
> +    LWLockRelease(WALInsertLock);
> 
> I don't think WALInsertLock needs to be hold here because there is no
> concurrently running process which can access Insert.fullPageWrites.
> For example, Insert->currpos and Insert->LogwrtResult are also changed
> without the lock there.
> 

Yes. 

> The source comment of XLogReportParameters() needs to be modified.

Yes, too.


--------------------------------------------
Jun Ishizuka
NTT Software Corporation
TEL:045-317-7018
E-Mail: ishizuka.jun@po.ntts.co.jp
--------------------------------------------




pgsql-hackers by date:

Previous
From: Jun Ishiduka
Date:
Subject: Re: Online base backup from the hot-standby
Next
From: Brar Piening
Date:
Subject: Commitfest app not exporting "moved to another commitfest" to rss