Re: pgsql: Allow more include files to be compiled in their own by adding m - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Allow more include files to be compiled in their own by adding m
Date
Msg-id 201109011122.p81BMC821327@momjian.us
Whole thread Raw
In response to Re: pgsql: Allow more include files to be compiled in their own by adding m  (Bruce Momjian <bruce@momjian.us>)
List pgsql-committers
Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Allow more include files to be compiled in their own by adding missing
> > > include dependencies.
> >
> > This patch broke the build on buildfarm member mongoose.
>
> This is the change I made to contrib/cube.  I see other contrib modules
> including fmgr.h too:
>
>     diff --git a/contrib/cube/cubedata.h b/contrib/cube/cubedata.h
>     new file mode 100644
>     index fd0c26a..9760162
>     *** a/contrib/cube/cubedata.h
>     --- b/contrib/cube/cubedata.h
>     ***************
>     *** 1,5 ****
>     --- 1,7 ----
>       /* contrib/cube/cubedata.h */
>
>     + #include "fmgr.h"
>     +
>       #define CUBE_MAX_DIM (100)
>
>       typedef struct NDBOX
>
> I can remove it and we can see if it fixes things.  Should I?

I am reverting this include change.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgsql: Allow more include files to be compiled in their own by adding m
Next
From: Bruce Momjian
Date:
Subject: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge