Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Allow more include files to be compiled in their own by adding m - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Allow more include files to be compiled in their own by adding m
Date
Msg-id 201109010207.p8127qL23625@momjian.us
Whole thread Raw
In response to Re: pgsql: Allow more include files to be compiled in their own by adding m  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Allow more include files to be compiled in their own by adding m
List pgsql-committers
Tree view 
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Allow more include files to be compiled in their own by adding missing
> > include dependencies.
>
> This patch broke the build on buildfarm member mongoose.

This is the change I made to contrib/cube.  I see other contrib modules
including fmgr.h too:

    diff --git a/contrib/cube/cubedata.h b/contrib/cube/cubedata.h
    new file mode 100644
    index fd0c26a..9760162
    *** a/contrib/cube/cubedata.h
    --- b/contrib/cube/cubedata.h
    ***************
    *** 1,5 ****
    --- 1,7 ----
      /* contrib/cube/cubedata.h */

    + #include "fmgr.h"
    +
      #define CUBE_MAX_DIM (100)

      typedef struct NDBOX

I can remove it and we can see if it fixes things.  Should I?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: Fix pg_upgrade to preserve toast relfrozenxids for old 8.3 serve
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql: Allow more include files to be compiled in their own by adding m