Re: pgsql: Properly handle Win32 paths of 'E:abc', which can be either abso - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Properly handle Win32 paths of 'E:abc', which can be either abso
Date
Msg-id 201102130514.p1D5EIh10809@momjian.us
Whole thread Raw
In response to Re: pgsql: Properly handle Win32 paths of 'E:abc', which can be either abso  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Properly handle Win32 paths of 'E:abc', which can be either absolute or
> > relative, by creating a function path_is_relative_and_below_cwd() to
> > check for specific requirements.  It is unclear if this fixes a security
> > problem or not but the new code is more robust.
>
> Surely this test is backwards?
>
> +bool
> +path_is_relative_and_below_cwd(const char *path)
> +{
> +   if (!is_absolute_path(path))
> +       return false;

Yes, sorry, corrected.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Refactor ALTER EXTENSION UPDATE to have cleaner multi-step seman
Next
From: Bruce Momjian
Date:
Subject: pgsql: Fix reverse 'if' test in path_is_relative_and_below_cwd(), per T