plperl message style on newly added messages - Mailing list pgsql-hackers

From Alvaro Herrera
Subject plperl message style on newly added messages
Date
Msg-id 20100215150250.GD2982@alvh.no-ip.org
Whole thread Raw
Responses Re: plperl message style on newly added messages
List pgsql-hackers
Hi,

I notice that the new plperl error messages are somewhat out of line of
our usual style:
           ereport(ERROR,                   (errcode(ERRCODE_INTERNAL_ERROR),                       errmsg("while
executingutf8fix"),                       errdetail("%s", strip_trailing_ws(SvPV_nolen(ERRSV))) ));
 

I think the errdetail field should really be errmsg, and the errdetail
should be errcontext.

There are several messages like this.

Should this be fixed?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Explain buffers display units.
Next
From: Robert Haas
Date:
Subject: Re: TCP keepalive support for libpq