Re: plperl message style on newly added messages - Mailing list pgsql-hackers

From Robert Haas
Subject Re: plperl message style on newly added messages
Date
Msg-id 603c8f071002150710o6bd7e23eya42ffedfbf516363@mail.gmail.com
Whole thread Raw
In response to plperl message style on newly added messages  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: plperl message style on newly added messages
List pgsql-hackers
On Mon, Feb 15, 2010 at 10:02 AM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> I notice that the new plperl error messages are somewhat out of line of
> our usual style:
>
>            ereport(ERROR,
>                    (errcode(ERRCODE_INTERNAL_ERROR),
>                        errmsg("while executing utf8fix"),
>                        errdetail("%s", strip_trailing_ws(SvPV_nolen(ERRSV))) ));
>
> I think the errdetail field should really be errmsg, and the errdetail
> should be errcontext.
>
> There are several messages like this.
>
> Should this be fixed?

Yes.

...Robert


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: TCP keepalive support for libpq
Next
From: Tom Lane
Date:
Subject: Re: pg_dump sort order for functions