Re: ECPGset_var - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: ECPGset_var
Date
Msg-id 20100126183245.GG3380@alvh.no-ip.org
Whole thread Raw
In response to Re: ECPGset_var  (Boszormenyi Zoltan <zb@cybertec.at>)
Responses Re: ECPGset_var  (Boszormenyi Zoltan <zb@cybertec.at>)
List pgsql-hackers
Boszormenyi Zoltan wrote:

> Thanks for analyzing it, patch is attached. I downloaded
> and installed ICC, so I could reproduce the difference.

Why not have a single function that does both things in a single call?
It doesn't look like there's any place that calls the function with only
one value for "insert" ...

I happened to notice this misleading comment:
       char temp[20]; /* this should be sufficient unless you have 8 byte integers */

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Next
From: Josh Berkus
Date:
Subject: Re: Dividing progress/debug information in pg_standby, and stat before copy