Re: per-tablespace random_page_cost/seq_page_cost - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: per-tablespace random_page_cost/seq_page_cost
Date
Msg-id 20091103125152.GB7088@alvh.no-ip.org
Whole thread Raw
In response to Re: per-tablespace random_page_cost/seq_page_cost  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: per-tablespace random_page_cost/seq_page_cost
List pgsql-hackers
Robert Haas escribió:
> On Tue, Nov 3, 2009 at 6:25 AM, Alvaro Herrera
> <alvherre@commandprompt.com> wrote:
> >> > If this is the case, then I think we could just decide that their name
> >> > is reloptions due to hysterical reasons and be done with it.
> >>
> >> Yeah.  It's particularly unfortunate that we call them "reloptions" in
> >> the code but "storage parameters" in the documentation.  Neither is a
> >> particularly good name, and having two different ones is extra-poor.
> >> But I'm fine with leaving the names as they are and moving on, if no
> >> one objects too much.  Speak now or don't complain about it after I
> >> write the patch!
> >
> > Maybe after we move to Git we can rename them in the code?
> 
> I'm OK with renaming it before I start working on the main patch, or
> after it's committed, or never.  I just don't want to have to rebase
> it in the middle.

I think "after we move to Git" goes well after "after your patch is
committed", so we're OK.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: per-tablespace random_page_cost/seq_page_cost
Next
From: Robert Haas
Date:
Subject: Re: per-tablespace random_page_cost/seq_page_cost