On Mon, Apr 27, 2009 at 01:11:44PM -0400, Tom Lane wrote:
> David Fetter <david@fetter.org> writes:
> > I have a handle on the problem, which is that the tab completion
> > code assumes, wrongly, that it only needs to deal with fixed
> > strings. It's actually been false for some time in the \div case,
> > for example. The S option has shattered the fixed-string
> > assumption.
>
> Check.
>
> > I'm proposing to refactor the backslash handling code so all of it
> > is in one spot with differences in the target list and WHERE
> > clauses depending on whether it's tab completion, S, +, what I'm
> > thinking of as second-level options--the [ivt]* in \d[ivt]* and
> > the [antw]* in \df[antw]*[S+]--and patterns.
>
> > Does this sound reasonable?
>
> It seems like rather a large change to be making in beta. Can you
> make a small patch that fixes the immediate problem, and leave the
> refactoring for 8.5?
The hack I've come up with short of the refactor is to duplicate a lot
of the backslash handling code from command.c and describe.c. It
doesn't strike me as being all that much less work than the refactor.
Is the hack worth doing?
What other ways to approach this have I missed?
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
