Re: psql with "Function Type" in \df - Mailing list pgsql-hackers

From Tom Lane
Subject Re: psql with "Function Type" in \df
Date
Msg-id 7246.1240852304@sss.pgh.pa.us
Whole thread Raw
In response to Re: psql with "Function Type" in \df  (David Fetter <david@fetter.org>)
Responses Re: psql with "Function Type" in \df  (David Fetter <david@fetter.org>)
List pgsql-hackers
David Fetter <david@fetter.org> writes:
> I have a handle on the problem, which is that the tab completion code
> assumes, wrongly, that it only needs to deal with fixed strings.  It's
> actually been false for some time in the \div case, for example.  The
> S option has shattered the fixed-string assumption.

Check.

> I'm proposing to refactor the backslash handling code so all of it is
> in one spot with differences in the target list and WHERE clauses
> depending on whether it's tab completion, S, +, what I'm thinking of
> as second-level options--the [ivt]* in \d[ivt]* and the [antw]* in
> \df[antw]*[S+]--and patterns.

> Does this sound reasonable?

It seems like rather a large change to be making in beta.  Can you make
a small patch that fixes the immediate problem, and leave the
refactoring for 8.5?
        regards, tom lane


pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: psql with "Function Type" in \df
Next
From: David Fetter
Date:
Subject: Re: psql with "Function Type" in \df