Re: psql with "Function Type" in \df - Mailing list pgsql-hackers

Alvaro Herrera wrote:
> Kevin Grittner wrote:
> > Bruce Momjian <bruce@momjian.us> wrote:
> >
> > > \df[S+] [PATTERN]      list functions
> > > \df[antwS+] [PATTERN]  list only agg/normal/trigger/window functions
> >
> > Shouldn't that second line have some curly braces?  Like maybe:
> >
> > \df{antw}[S+] [PATTERN]  list only agg/normal/trigger/window functions
> >
> > Technically, it should probably be even more verbose, but this might
> > be adequate.
>
> I suggested this to Bruce over IM:
>
> \df[antw][S+]     list [only agg/normal/trigger/window] functions
>
> (one line only, removing the second redundant line).  This seems
> clea[nr]er to me.  Bruce says it would confuse users.  But really, if
> you can understand the [S+] stuff you should be able to get the [antw]
> stuff too, right?

I merged the entries into one line:

    \df[antwS+] [PATTERN]  list (only agg/normal/trigger/window) functions

I didn't feel I had room to do [][] like Alvaro suggested.  I also went
with parntheses in the description.  Are brackets better there?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: doc/src/sgml/ref/psql-ref.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/psql-ref.sgml,v
retrieving revision 1.224
diff -c -c -r1.224 psql-ref.sgml
*** doc/src/sgml/ref/psql-ref.sgml    21 Apr 2009 15:49:06 -0000    1.224
--- doc/src/sgml/ref/psql-ref.sgml    21 Apr 2009 17:21:56 -0000
***************
*** 1038,1045 ****


        <varlistentry>
!         <term><literal>\df[S+] [ <replaceable class="parameter">pattern</replaceable> ]</literal></term>
!         <term><literal>\df[antw][S+] [ <replaceable class="parameter">pattern</replaceable> ]</literal></term>

          <listitem>
          <para>
--- 1038,1044 ----


        <varlistentry>
!         <term><literal>\df[antwS+] [ <replaceable class="parameter">pattern</replaceable> ]</literal></term>

          <listitem>
          <para>
Index: src/bin/psql/help.c
===================================================================
RCS file: /cvsroot/pgsql/src/bin/psql/help.c,v
retrieving revision 1.147
diff -c -c -r1.147 help.c
*** src/bin/psql/help.c    21 Apr 2009 15:49:06 -0000    1.147
--- src/bin/psql/help.c    21 Apr 2009 17:21:57 -0000
***************
*** 205,212 ****
      fprintf(output, _("  \\des[+] [PATTERN]      list foreign servers\n"));
      fprintf(output, _("  \\deu[+] [PATTERN]      list user mappings\n"));
      fprintf(output, _("  \\dew[+] [PATTERN]      list foreign-data wrappers\n"));
!     fprintf(output, _("  \\df[S+] [PATTERN]      list functions\n"));
!     fprintf(output, _("  \\df[antwS+] [PATTERN]  list only agg/normal/trigger/window functions\n"));
      fprintf(output, _("  \\dF[+]  [PATTERN]      list text search configurations\n"));
      fprintf(output, _("  \\dFd[+] [PATTERN]      list text search dictionaries\n"));
      fprintf(output, _("  \\dFp[+] [PATTERN]      list text search parsers\n"));
--- 205,211 ----
      fprintf(output, _("  \\des[+] [PATTERN]      list foreign servers\n"));
      fprintf(output, _("  \\deu[+] [PATTERN]      list user mappings\n"));
      fprintf(output, _("  \\dew[+] [PATTERN]      list foreign-data wrappers\n"));
!     fprintf(output, _("  \\df[antwS+] [PATTERN]  list (only agg/normal/trigger/window) functions\n"));
      fprintf(output, _("  \\dF[+]  [PATTERN]      list text search configurations\n"));
      fprintf(output, _("  \\dFd[+] [PATTERN]      list text search dictionaries\n"));
      fprintf(output, _("  \\dFp[+] [PATTERN]      list text search parsers\n"));