Re: unchecked out of memory in postmaster.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: unchecked out of memory in postmaster.c
Date
Msg-id 20090407011113.GO4525@alvh.no-ip.org
Whole thread Raw
In response to Re: unchecked out of memory in postmaster.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: unchecked out of memory in postmaster.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > I think a patch to solve this is as simple as the attached.
> 
> I guess I need to point out that those ereport calls already pose a far
> more substantial risk of palloc failure than the DLNewElem represents.

Hmm, do they?  I mean, don't they use ErrorContext, which is supposed to
be preallocated?

> You seem to have forgotten about releasing the DLElem if the fork fails,
> too.

Doh, sorry about that.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: A renewed plea for inclusion of zone.tab
Next
From: Tom Lane
Date:
Subject: Re: unchecked out of memory in postmaster.c