Postgres Pro
Downloads
Home   >   mailing lists

Re: unchecked out of memory in postmaster.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: unchecked out of memory in postmaster.c
Date
Msg-id 24283.1239060709@sss.pgh.pa.us
Whole thread Raw
In response to Re: unchecked out of memory in postmaster.c  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: unchecked out of memory in postmaster.c  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Tree view 
Alvaro Herrera <alvherre@commandprompt.com> writes:
> I think a patch to solve this is as simple as the attached.

I guess I need to point out that those ereport calls already pose a far
more substantial risk of palloc failure than the DLNewElem represents.

You seem to have forgotten about releasing the DLElem if the fork fails,
too.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: default parameters for built-in functions (was Re: Documentation Update: Document pg_start_backup checkpoint behavior)
Next
From: Tom Lane
Date:
Subject: Re: default parameters for built-in functions (was Re: Documentation Update: Document pg_start_backup checkpoint behavior)