Re: patch to fix client only builds - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: patch to fix client only builds
Date
Msg-id 200901090349.n093nmj20189@momjian.us
Whole thread Raw
In response to Re: patch to fix client only builds  ("Merlin Moncure" <mmoncure@gmail.com>)
List pgsql-hackers
Did we address this?

---------------------------------------------------------------------------

Merlin Moncure wrote:
> On Thu, Nov 6, 2008 at 12:45 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > "Merlin Moncure" <mmoncure@gmail.com> writes:
> >> IMO, the client only build should be fixed, so we can:
> >> *) put the makefile hack I proposed in
> >> *) implement the keywords.c change suggested above
> >> *) set up backend/parser symlink from different/additional place.
> >
> > The last of these seems the correct fix.  A minimal change would be
> > something like
> >
> >  submake-backend:
> > +       $(MAKE) -C $(top_builddir)/src/backend $(top_builddir)/src/include/parser/gram.h
> >        $(MAKE) -C $(top_builddir)/src/backend/parser keywords.o
> >
> 
> Noticed another issue with 'client only' type installs in the
> Makefile.  Shouldn't make install on libpq install postgres_ext.h in
> addition to the interface headers?
> 
> install: all installdirs install-lib
>   $(INSTALL_DATA) $(srcdir)/libpq-fe.h '$(DESTDIR)$(includedir)'
>   $(INSTALL_DATA) $(srcdir)/libpq-events.h '$(DESTDIR)$(includedir)'
>   $(INSTALL_DATA) $(srcdir)/libpq-int.h '$(DESTDIR)$(includedir_internal)'
>   $(INSTALL_DATA) $(srcdir)/pqexpbuffer.h '$(DESTDIR)$(includedir_internal)'
>   $(INSTALL_DATA) $(srcdir)/pg_service.conf.sample
> '$(DESTDIR)$(datadir)/pg_service.conf.sample'
> 
> merlin
> 
> -- 
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: New patch for Column-level privileges
Next
From: KaiGai Kohei
Date:
Subject: Updates of SE-PostgreSQL 8.4devel patches (r1398)