Re: NDirectFileRead and Write - Mailing list pgsql-hackers

From ITAGAKI Takahiro
Subject Re: NDirectFileRead and Write
Date
Msg-id 20080912191753.5B98.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: NDirectFileRead and Write  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: NDirectFileRead and Write  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: NDirectFileRead and Write  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> wrote:

> * Let's rename them BufFileReadCount and BufFileWriteCount to reflect
> their actual purpose.

It looks good. No one uses NDirectFileRead/Write variables now,
so we can rename it freely.

BTW, we have the word 'Direct' in ShowBufferUsage().
Can I keep it as-is?

ShowBufferUsage()
!   Shared blocks: ...
!   Local  blocks: ...
!   Direct blocks: <R> read, <W> written


> * In any case I agree that the current arrangement
> with execdebug.h declaring variables defined in bufmgr.c is just weird.

Ok.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center




pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Transaction Snapshots and Hot Standby
Next
From: Simon Riggs
Date:
Subject: Re: Synchronous Log Shipping Replication