Re: NDirectFileRead and Write - Mailing list pgsql-hackers

From ITAGAKI Takahiro
Subject Re: NDirectFileRead and Write
Date
Msg-id 20080916104812.7E68.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: NDirectFileRead and Write  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: NDirectFileRead and Write  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Here is a revised patch to renewal NDirectFileRead/Write.

> Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > * Let's rename them BufFileReadCount and BufFileWriteCount to reflect
> > their actual purpose.
> > * In any case I agree that the current arrangement
> > with execdebug.h declaring variables defined in bufmgr.c is just weird.

- NDirectFile{Read|Write} are renamed to BufFile{Read|Write}Count.
- They are still declared in execdebug.h and buffile.c includes it.


I did not touch messages in ShowBufferUsage() in the patch.
I think it still has meaning because BufFile counters are
kinds of direct block access.

> ShowBufferUsage()
> !   Shared blocks: ...
> !   Local  blocks: ...
> !   Direct blocks: <R> read, <W> written

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Attachment

pgsql-hackers by date:

Previous
From: KaiGai Kohei
Date:
Subject: Re: Proposal of SE-PostgreSQL patches (for CommitFest:Sep)
Next
From: Tom Lane
Date:
Subject: Re: plpgsql is not translate-aware