Re: [PATCH]-hash index improving - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH]-hash index improving
Date
Msg-id 20080717164239.GH3934@alvh.no-ip.org
Whole thread Raw
In response to [PATCH]-hash index improving  ("Xiao Meng" <mx.cogito@gmail.com>)
Responses Re: [PATCH]-hash index improving  ("Jonah H. Harris" <jonah.harris@gmail.com>)
Re: [PATCH]-hash index improving  (Kenneth Marshall <ktm@rice.edu>)
Re: [PATCH]-hash index improving  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Xiao Meng escribió:
> The patch store hash code only in the index tuple.
> It based on  Neil Conway's patch with an old version of PostgreSQL.
> It passes the regression test but I didn't test the performance yet.
> Anyone interested can make a performance test;-)
> You can undefine the macro HASHVALUE_ONLY in hash.h to get the
> original implementation.

I think having the HASHVALUE_ONLY define is not a good idea -- it just
makes the patch harder to read.  I suggest just removing the old code
and putting the new code in place.  (That's why we have revision
control.)


-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Decibel!
Date:
Subject: Re: postmaster.pid not visible
Next
From: "David E. Wheeler"
Date:
Subject: Re: PATCH: CITEXT 2.0 v4