Re: [PATCH]-hash index improving - Mailing list pgsql-hackers

From Jonah H. Harris
Subject Re: [PATCH]-hash index improving
Date
Msg-id 36e682920807171048u4c79c084n2e49f3230a1b508d@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH]-hash index improving  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
On Thu, Jul 17, 2008 at 12:42 PM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> I think having the HASHVALUE_ONLY define is not a good idea -- it just
> makes the patch harder to read.  I suggest just removing the old code
> and putting the new code in place.  (That's why we have revision
> control.)

Agreed.  I'm also getting a crash on it with large data sets, so we'll
make sure to get those fixed in the next version of the patch.

-Jonah


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: autovacuum crash due to null pointer
Next
From: Kenneth Marshall
Date:
Subject: Re: [PATCH]-hash index improving