Re: Extending grant insert on tables to sequences - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Extending grant insert on tables to sequences
Date
Msg-id 20080709191125.GK3946@alvh.no-ip.org
Whole thread Raw
In response to Re: Extending grant insert on tables to sequences  (Abhijit Menon-Sen <ams@oryx.com>)
Responses Re: Extending grant insert on tables to sequences  (Abhijit Menon-Sen <ams@oryx.com>)
List pgsql-hackers
Abhijit Menon-Sen escribió:
> At 2008-07-08 09:32:44 -0400, alvherre@commandprompt.com wrote:

> > Wouldn't it be clearer to build a list with all the sequences owned by
> > the tables in istmt.objects, and then call ExecGrantStmt_oids() a
> > single time with the big list?
> 
> i.e., to hoist most of the istmt_seq initialisation out of the loop,
> right? Yes, that makes sense.

No, actually I meant having a lone "list = lappend(list, newseq);" in
the loop, so that ExecGrantStmt_oids is called only once.  The
initialization is done only once too, of course.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: "Ken Camann"
Date:
Subject: Re: Summary of some postgres portability issues
Next
From: Tom Lane
Date:
Subject: Re: CommitFest: how does handoff work for non-committer reviewers?