At 2008-07-08 09:32:44 -0400, alvherre@commandprompt.com wrote:
>
> > > The idea of this patch is to avoid the need to make explicit
> > > grants on sequences owned by tables. [...]
>
> I had a look at this patch and it looks good. The only thing that's
> not clear to me is whether we have agreed we want this to be the
> default behavior?
For what it's worth, I quite like the idea.
(I looked at the patch, and it looks good to me too.)
> Wouldn't it be clearer to build a list with all the sequences owned by
> the tables in istmt.objects, and then call ExecGrantStmt_oids() a
> single time with the big list?
i.e., to hoist most of the istmt_seq initialisation out of the loop,
right? Yes, that makes sense.
-- ams
