David Fetter wrote:
> That new version stamper calls out to sed, when perl is perfectly
> capable of doing the same work itself and not spawning 30 shells in
> the process.
That's great. Please send a patch to improve the stamper. (Are you
really worried about its performance, given that it runs about once a
month on average?)
> > (If you think the sed scripts are crufty, check out some of the awk
> > we use.)
>
> Another cleanup opportunity :)
I'm not sure it's the same case here, because the stamper is supposed to
run on very few machines (mostly just Marc's) whereas the rest of the
stuff is supposed to run on many others.
> > Is perl currently required to build from tarball? If not, you would
> > be placing an additional build requirement and there may still be a
> > few odd build environments that don't sport perl by default.
>
> This is 2008, and it's silly to pretend we need to support this
> "requirement" on systems where people are building Postgres.
Maybe, or maybe not. Do these platforms all have Perl?
gypsy_moth Solaris 8 SUN Studio 8 sparc
warthog UnixWare 7.1.4 cc 4.2 isa
canary NetBSD 1.6 gcc 2.95.3 x86
kudu Solaris 9 Sun WorkShop 6 update 2 C 5.3 x86
spoonbill OpenBSD OpenBSD 4.2 gcc gcc 3.3.5 Sparc64
grebe AIX 5.3 GCC 4.0.1 PPC
osprey NetBSD 2.0 gcc 3.3.3 m68k
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
