Re: Hiding undocumented enum values? - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Hiding undocumented enum values?
Date
Msg-id 20080527200545.33460bcb@mha-laptop.hagander.net
Whole thread Raw
In response to Re: Hiding undocumented enum values?  ("Alex Hunsaker" <badalex@gmail.com>)
Responses Re: Hiding undocumented enum values?  ("Alex Hunsaker" <badalex@gmail.com>)
List pgsql-hackers
Alex Hunsaker wrote:
> On Tue, May 27, 2008 at 10:20 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > I am wondering if it's a good idea to hide the redundant entries
> > to reduce clutter in the pg_settings display.  (We could do this
> > by adding a "hidden" boolean to struct config_enum_entry.)
> > Thoughts?
> 
> +1
> 
> >                        regards, tom lane
> 
> Maybe something like the attached patch?

Oops, missed that there was a patch posted already. Looks like the way
to do it (except I'd move the comment :-P) if that's the way we go.


> I looked into just making it a string so we could use parse_bool...
> because backslash_quote seems to be the exception not the rule.  But I
> decided having a hidden flag seems more useful anyway...

It used to be a string. We don't want that, because then we can't tell
the client which possible values are available. That's the whole reason
for the creation of the enum type gucs...

//Magnus


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Hiding undocumented enum values?
Next
From: Magnus Hagander
Date:
Subject: Re: Remove redundant extra_desc info for enum GUC variables?