Re: Replace offnum++ by OffsetNumberNext - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Replace offnum++ by OffsetNumberNext
Date
Msg-id 200805100050.m4A0o3H25811@momjian.us
Whole thread Raw
In response to Re: Replace offnum++ by OffsetNumberNext  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Fujii Masao <fujii.masao@oss.ntt.co.jp> writes:
> > This is the patch replace offnum++ by OffsetNumberNext.
> > According to off.h, OffsetNumberNext is the macro prepared to
> > disambiguate the different manipulations on OffsetNumbers.
> > But, increment operator was used in some places instead of the macro.
>
> I wonder if we shouldn't go the other way, ie, use ++ everywhere.
> OffsetNumberNext seems like just useless obscurantism ...

The only value I saw to OffsetNumberNext was the fact is does int16
increment, with casting.  There is also the comment:

 *      Increments/decrements the argument.  These macros look pointless
 *      but they help us disambiguate the different manipulations on
 *      OffsetNumbers (e.g., sometimes we subtract one from an
 *      OffsetNumber to move back, and sometimes we do so to form a
 *      real C array index).

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: "Alex Hunsaker"
Date:
Subject: Re: [badalex@gmail.com: Re: [BUGS] Problem identifying constraints which should not be inherited]
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCH] sh: Add support Renesas SuperH