Re: Replace offnum++ by OffsetNumberNext - Mailing list pgsql-patches

From Tom Lane
Subject Re: Replace offnum++ by OffsetNumberNext
Date
Msg-id 8309.1207343063@sss.pgh.pa.us
Whole thread Raw
In response to Replace offnum++ by OffsetNumberNext  (Fujii Masao <fujii.masao@oss.ntt.co.jp>)
Responses Re: Replace offnum++ by OffsetNumberNext
List pgsql-patches
Fujii Masao <fujii.masao@oss.ntt.co.jp> writes:
> This is the patch replace offnum++ by OffsetNumberNext.
> According to off.h, OffsetNumberNext is the macro prepared to
> disambiguate the different manipulations on OffsetNumbers.
> But, increment operator was used in some places instead of the macro.

I wonder if we shouldn't go the other way, ie, use ++ everywhere.
OffsetNumberNext seems like just useless obscurantism ...

            regards, tom lane

pgsql-patches by date:

Previous
From: Teodor Sigaev
Date:
Subject: Partial match in GIN
Next
From: "Pavel Stehule"
Date:
Subject: fixing sql generated features - plpgsql case statement