Tom Lane wrote:
> Greg Smith <gsmith@gregsmith.com> writes:
> > On Fri, 14 Mar 2008, Tom Lane wrote:
> >> Yeah, -s is only meaningful when given with -i. Maybe someday we ought
> >> to fix pgbench to complain if you try to set it at other times.
>
> > You have to pass -s in to the actual run if you're specifying your own
> > custom script(s) using -f and you want the :scale variable to be defined.
>
> Right, I knew that at one time ;-)
>
> > The way the option parsing code is done would make complaining in the case
> > where your parameter is ignored a bit of a contortion. The part that
> > detects based on the database is after all the other parsing because the
> > connection has to be brought up first.
>
> Yeah. But couldn't we have that part issue a warning if -s had been set
> on the command line?
Patch attached that issues a warning.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Index: contrib/pgbench/pgbench.c
===================================================================
RCS file: /cvsroot/pgsql/contrib/pgbench/pgbench.c,v
retrieving revision 1.79
diff -c -c -r1.79 pgbench.c
*** contrib/pgbench/pgbench.c 19 Mar 2008 03:33:21 -0000 1.79
--- contrib/pgbench/pgbench.c 7 May 2008 21:36:42 -0000
***************
*** 1627,1632 ****
--- 1627,1635 ----
}
}
+ if (!is_init_mode && scale)
+ fprintf(stderr, "Scale specification ignored because init mode (-i) not specified\n");
+
if (argc > optind)
dbName = argv[optind];
else
