Bruce Momjian wrote:
> Andrew Dunstan wrote:
> >
> >
> > Alvaro Herrera wrote:
> > >>> That sounds like you want to log when the collector starts, which is not
> > >>> the case and is confusing -- what collector is it talking about? This
> > >>> is about starting the log collector.
> > >>>
> > >> Yea, good point. I was just wondering because I don't see 'start' used
> > >> in anywhere at the beginning of a GUC variable.
> > >
> > > Good point too. In other places we just name the feature that's to be
> > > started, for example we don't use "start_autovacuum".
> >
> > How about just "log_collector" then?
> >
> > Lets decide ASAP please - I want to get this committed.
>
> Works for me, or enable_log_collector? Based on Alvaro's comments,
> log_collector does sound like we are logging collector activity.
The problem here is that "log" seems to be a verb in "log_collector"
which is what makes it confusing. So we need another verb to make it
clear that "log" is not one. This is not a problem with "autovacuum"
because that one cannot be confused with a verb.
start_log_collector still gets my vote.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
