Re: Better error message for select_common_type() - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Better error message for select_common_type()
Date
Msg-id 200704240018.18611.peter_e@gmx.net
Whole thread Raw
In response to Re: Better error message for select_common_type()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Better error message for select_common_type()
List pgsql-hackers
Tom Lane wrote:
> +1 on using the parser location mechanism and avoiding the
> terminology problem altogether.

I figured we would let the parser only point to the UNION or VALUES or 
whatever word.  It would be fairly cumbersome to drag the individual 
expression positions down into select_common_value() for full 
precision.

> I fear though that we're not set up 
> to have multiple locations in one error report.  Will it be
> sufficient if we point at one of the two offending expressions?  (I'd
> guess pointing at the second makes the most sense, if feasible.)

I don't think that would help.  In the example I was looking at 90 
expression and I had no idea in most cases what their results types 
are, so if it tells me that the 15th expression somewhere doesn't 
match, I would need to know which is the other mismatching one.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [pgsql-advocacy] Wild idea: 9.0?
Next
From: Alvaro Herrera
Date:
Subject: Re: Improving deadlock error messages