Re: Improving deadlock error messages - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Improving deadlock error messages
Date
Msg-id 20070423222647.GG12624@alvh.no-ip.org
Whole thread Raw
In response to Re: Improving deadlock error messages  (Neil Conway <neilc@samurai.com>)
List pgsql-hackers
Neil Conway wrote:
> On Mon, 2007-04-23 at 17:38 -0400, Tom Lane wrote:
> > I'm really still opposed to the entire concept.  You're proposing to put
> > a lot of fragile-looking code into a seldom-exercised error path.
> 
> There's certainly not a "lot" of code: the patch just adds a few
> syscache lookups, wrapped in a PG_LOCK_NOWAIT() block.
> 
> As for fragility, I think the important point is whether it's safe to
> siglongjmp() out of LockAcquire(); the rest is just window dressing.

We have some elog(ERROR) calls in LockAcquire, so yes, there are some
siglongjmp calls already in there.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Better error message for select_common_type()
Next
From: Tom Lane
Date:
Subject: Re: Better error message for select_common_type()